cheat.sh icon indicating copy to clipboard operation
cheat.sh copied to clipboard
verified publisher icon chubin

added ?T option to run-tests.sh

Open pkhanpara opened this issue 3 years ago • 4 comments

added ?T option to run-tests.sh to ignore ansi styling mismatch errors and recaptured the outputs. Fixing https://github.com/chubin/cheat.sh/issues/345

pkhanpara avatar Jul 07 '22 21:07 pkhanpara

We will need test for highlighting, but that could be another issue to keep this minimal.

Looks good, but tests are failing. Probably escaping got wrong at some point so the server returns StackOverflow answers instead of stored data.

abitrolly avatar Jul 08 '22 06:07 abitrolly

I've fixed the escaping. Now it may show one unrelated test failing in both modes, which looks like a different issue. And there is one more unrelated test failing in standalone mode.

pkhanpara avatar Jul 09 '22 18:07 pkhanpara

Added #352 for failing test.

I would actually get rid of eval logic, because I don't really get what it does. But it doesn't seem relevant to this PR.

Need @chubin feedback on the whole idea of suppressing colors in tests.

abitrolly avatar Jul 10 '22 08:07 abitrolly

@chubin what do you think about suppressing colors in tests? Feel free to point out an alternative approach if you don't feel like this is the right way to do it. Thanks!

pkhanpara avatar Jul 15 '22 01:07 pkhanpara