Chris Sienkiewicz

Results 32 comments of Chris Sienkiewicz

@CyrusNajmabadi is out this week, but i'll take a look. Your analysis seems correct, so should hopefully be a fairly easy fix.

@phil-allen-msft Compiler is working as expected, so moving to tooling for triage of the squiggles not showing.

@SteveSandersonMS @chsienki Yeah, if we're going to have a directive to opt-in then it's a compiler feature either way. If we're requiring users to opt-in, it makes sense to me...

@mkArtakMSFT Looking at the repro this is occurring as part of runtime compilation, specifically as part of this call stack: https://github.com/dotnet/aspnetcore/blob/55e125cb3625f43ea7095c7e0cc1a9abda141992/src/Mvc/Mvc.Razor.RuntimeCompilation/src/RuntimeViewCompiler.cs#L312 Previously we decided to track issues related to RC...

Ok, I at least understand the issue: As part of the `MetadataReferenceFeatureProvider` we go over each application part and get the contained reference paths: https://github.com/dotnet/aspnetcore/blob/5599953b969d73304a710417dc47bb2fd800d4ce/src/Mvc/Mvc.Razor/src/Compilation/MetadataReferenceFeatureProvider.cs#L36-L48 That in turn creates a...

@sandermvanvliet-stack thanks for the detailed analysis! That certainly seems like a plausible explanation for what is happening. @jaredpar @danroth27 Runtime compilation lives in aspnetcore, but I guess we're the closest...

Ah yeah, this is a fallout of the runtime fuse changes (so a real break). That `@` in count isn't a razor `@` but a C# identifier escape character. We're...