chrysn

Results 847 comments of chrysn

Well the *functions* can, they just can't under the precise circumstances they're used in. Anyway, a more robust phrasing would be: > Crates providing libraries should never use functions or...

Looks good, thanks. Please squash (either into one commit, or into the "update reference" and a "remove label" commit), and prefix them with "cord/doc:" or similar as per the project's...

This looks good to me if the intention around the error type is to have details perfectly suited to specific transports (that is not clear to me from its docs;...

For understanding how to place the Noise error in more abstract categories: What'd be the criterion for something to be noise, and how does it differ from parity checks or...

Are you sure `BSD-3-Clause AND LicenseRef-JPEG-XL-Google-Patent` is accurate? This would imply that a user has to adhere (and, in case of cargo-deny etc, allow-list) *both* licenses -- but at least...

The "OR" here is not exclusive: The set of rights the user gets is "OR"ed, the user doesn't get just one (that'd be XOR). The JPEG-XL-Google-Patent conveys no copyright license....

Thanks for digging into it, this looks like a good solution!