ArchReactorOS
ArchReactorOS copied to clipboard
chrwei
web based software system for manging membership based community
Suggestion: Remove all specific code from admin/payment.php. Define interfaces and an abstract class that need to be implemented by new payment gateways.
Most frontend files such as order.php or admin/payment.php have very long functions that should be broken into several functions and possibly even turned into OO code. Variables should be renamed...
Chmod'ding to 777 is BAD. Instruct site admins to change the file owner and if required set file permissions to 660 or 770 for directories.
Check the messges inside templates and source files. Improve the spelling and syntax.
If file aren't writeable or another error occurs, replace the "next step" button by a refresh button
When aros isn't installed, redirect to the installer.
init.php instantiates all classes by default. Only objects that are required everywhere and save state (i.s. Smarty, AdoDB, Dispatcher) should be instantiated by default.
Use php5 specifc OOP keywords such as public and private properties and methods, use magic functions such as __get(), __toString(), etc... Generally improve on Object Oriented code.
Make errors traceable by throwing exceptions where adequate and add exception handling for recoverable errors.
Some strings are inside gettext functions _() others are not. Put them all inside those functions to allow for full i18n.