chrono icon indicating copy to clipboard operation
chrono copied to clipboard

feat: Change to use `core::error::Error`

Open sorairolake opened this issue 1 year ago • 2 comments

Change to use core::error::Error instead of std::error::Error. The MSRV is bumped up to 1.81.0 by this change.

sorairolake avatar Sep 23 '24 05:09 sorairolake

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 91.12%. Comparing base (c8defc7) to head (b82f843). :warning: Report is 79 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1617   +/-   ##
=======================================
  Coverage   91.12%   91.12%           
=======================================
  Files          37       37           
  Lines       17123    17123           
=======================================
  Hits        15603    15603           
  Misses       1520     1520           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Sep 23 '24 06:09 codecov[bot]

I definitely don't want to take a 1.81 MSRV bump. We could make this an opt-in feature core-error, though?

djc avatar Sep 23 '24 07:09 djc