java-cef
java-cef copied to clipboard
custom library path option
Original report by Bart Adriaanse (Bitbucket: adriaanse, GitHub: adriaanse).
We have a project where JCEF is not on the system java.library.path so we are quite happy with the new SystemBootstrap feature !
However, after setting up our own loader to load the appropriate libraries, we find that JcefApp.java is still using the java.library.path property to locate other resources included with the platform binaries so it fails. We cannot add our JCEF folder to the java.library.path system property for specific reasons so we currently need to patch jcef.jar to make it work.
Therefore I propose to use an additional property, i.e. jcef.library.path to support the loading of JCEF resources from a non-standard location and will see if I can commit a pull request for this now.
Original comment by Bart Adriaanse (Bitbucket: adriaanse, GitHub: adriaanse).
I have just tried to follow the steps to commit a pull request but i think i got stuck because i am using Google authentication to access Bitbucket.
The request is in my fork ‘java-cef-adriaanse’ with Marshall Greenblatt as reviewer, I am not sure how to proceed from there now.
- String library_path = System.getProperty("java.library.path");
+ String library_path = System.getProperty("jcef.library.path", System.getProperty("java.library.path"));
Your change seems reasonable. See here for instructions on creating a PR.