subspace icon indicating copy to clipboard operation
subspace copied to clipboard

Subdoc Bugs exposed by libjxl

Open danakj opened this issue 2 years ago • 7 comments

JxlColorProfile

https://old.lucaversari.it/jpeg_xl_data/docs/JxlColorProfile.html

  • [ ] Here there's a data member icc whose type is ::(unnamed struct at /fast-data/libjxl/lib/include/jxl/cms_interface.h:47:3)
  • [ ] The struct fields links don't know the path to the struct's page, and are linking to .html

danakj avatar Sep 13 '23 23:09 danakj

  • https://old.lucaversari.it/jpeg_xl_data/docs/fn.JxlDecoderGetBoxType.html anonymous enum typedefs seem to confuse things
  • so does typedef char JxlBoxType[4]; apparently?
  • @ref doxygen commands (and others) are ignored
  • the following also doesn't get documented or linked:
/**
 * Opaque structure that holds the JPEG XL decoder.
 *
 * Allocated and initialized with @ref JxlDecoderCreate().
 * Cleaned up and deallocated with @ref JxlDecoderDestroy().
 */
typedef struct JxlDecoderStruct JxlDecoder;                               

veluca93 avatar Sep 13 '23 23:09 veluca93

typedefs are completely ignored atm, that one is in the TODOs. (except what we fixed today for typedef struct {} S;

danakj avatar Sep 13 '23 23:09 danakj

Running it on the full code, it seems that subdoc doesn't find a bunch of the hwy functions and namespaces.

veluca93 avatar Sep 14 '23 19:09 veluca93

Could you give a link to an example function?

danakj avatar Sep 14 '23 19:09 danakj

Could you give a link to an example function?

https://github.com/libjxl/libjxl/blob/97e5ab0916af36ff4ea8c47a21a551281ee79949/lib/jxl/inverse_mtf-inl.h#L53

this one is found, but only in namespaces N_SSE4 and N_SSE2, while the compile flags should cause it to appear also in i.e. namespace N_AVX2.

veluca93 avatar Sep 14 '23 20:09 veluca93

One possible cause is it skips decls that it has visited based on location. However subspace uses .inc files 5 times out of one header, and each one is visited separately.

danakj avatar Sep 14 '23 20:09 danakj

type aliases and macros now generate. macros only generate if the prefix matches a prefix from --include-macro-prefix

danakj avatar Dec 10 '23 22:12 danakj