hstspreload icon indicating copy to clipboard operation
hstspreload copied to clipboard

Published 20 hours ago • verified publisher icon chromium

Disable another test

Open nharper opened this issue 1 year ago • 4 comments

I missed this in PRs #131 and #135.

nharper avatar Jul 12 '23 20:07 nharper

Weird - https://github.com/chromium/hstspreload/actions/runs/5535335852 is the CI run from PR #135 that shows the failure of a test here. However, that PR also shows a CI run that's successful.

nharper avatar Jul 12 '23 20:07 nharper

Huh, I wonder if something changed from the httpbin side temporarily. Anyways, this LGTM since it still makes sense to skip the test (also, sorry that I missed this until now)

carlosjoan91 avatar Jul 14 '23 22:07 carlosjoan91

I don't think I sent this for review. I'm thinking instead of continuing to play whack-a-mole with tests like this, if we should just disable all tests that connect to external domains until #112 is resolved.

nharper avatar Jul 14 '23 22:07 nharper

Ack, one day I'll learn to use github for code review 🙃

carlosjoan91 avatar Jul 14 '23 23:07 carlosjoan91