badssl.com icon indicating copy to clipboard operation
badssl.com copied to clipboard

chore: redirect to the http page to actually check if the protocol update occurs

Open raklaptudirm opened this issue 1 year ago • 3 comments

Previously the https-everywhere link redirected to https://https-everywhere.badssl.com/, which would always show the https page, thus not checking for the protocol update. This has been changed to redirect to http://https-everywhere.badssl.com/, so that a protocol upgrade can actually be observed.

raklaptudirm avatar Aug 22 '24 12:08 raklaptudirm

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 22 '24 12:08 google-cla[bot]

This seems fairly reasonable to me, but the title of this PR doesn't make sense to me. This isn't changing any redirection, it's just updating the link on the index page, right?

lgarron avatar Aug 31 '24 23:08 lgarron

@lgarron Yes, that is what I meant. Feel free to change the name of the pr to something clearer.

raklaptudirm avatar Sep 01 '24 12:09 raklaptudirm