badssl.com icon indicating copy to clipboard operation
badssl.com copied to clipboard

Add `tls-v1-3` subdomain.

Open c0r0n3r opened this issue 4 years ago • 5 comments

This adds tls-v1-3 on port 1013, similar to how other protocol subdomains are implemented. Also adds the test to the dashboard.

c0r0n3r avatar Feb 18 '21 23:02 c0r0n3r

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Feb 18 '21 23:02 google-cla[bot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Feb 18 '21 23:02 google-cla[bot]

If I recall correctly, we were using a version of nginx that doesn't support TLS 1.3. Have you been able to test this change using Docker?

lgarron avatar Feb 19 '21 22:02 lgarron

If I recall correctly, we were using a version of nginx that doesn't support TLS 1.3.

That's unfortunately correct. Version 1.10.3 is used, 1.13 is needed atleast.

Is there a reason not to update to the latest stable version 1.20? It's not available in the default repo, but in the nginx repo. Maybe worth an update?

Maybe worth an update of the whole ubuntu from 16.04 to 20.04?

hellow554 avatar Nov 23 '21 06:11 hellow554

I join the topic, I think you need to quickly refresh your nginx. I would like to see a working subdomain in the mode tls 1.3 only

onefreddy avatar Jun 02 '22 16:06 onefreddy