chromebrew icon indicating copy to clipboard operation
chromebrew copied to clipboard

Fix unit tests reporting failures as cancellations

Open Zopolis4 opened this issue 1 year ago • 5 comments

Should fix what happened in #10356 where the failures counted as cancellations.

deliberately breaking a package to test.

Run the following to get this pull request's changes locally for testing.

CREW_REPO=https://github.com/Zopolis4/chromebrew.git CREW_BRANCH=slingin crew update \
&& yes | crew upgrade

Zopolis4 avatar Aug 26 '24 00:08 Zopolis4

nope, failures still only working on i686.

Zopolis4 avatar Aug 26 '24 00:08 Zopolis4

I do love that we are testing changes on i686 containers now. 😅

satmandu avatar Aug 26 '24 00:08 satmandu

oh also the yaml handoff has been broken for some time now it looks like-- the changed-files actions is not reporting the changed github workflows

Zopolis4 avatar Aug 26 '24 00:08 Zopolis4

oh also the yaml handoff has been broken for some time now it looks like-- the changed-files actions is not reporting the changed github workflows

I think I fixed that the other day...

satmandu avatar Aug 26 '24 00:08 satmandu

well i've changed the yaml in the unit test and the lint isnt running, so...

Zopolis4 avatar Aug 26 '24 01:08 Zopolis4