learnstorybook.com icon indicating copy to clipboard operation
learnstorybook.com copied to clipboard

Updated Japanese translation for Angular version of introduction to Storybook

Open nagashimam opened this issue 1 year ago • 13 comments

This PR updates Japanese translation for Angular version of introduction to Storybook

Angular版introduction to Storybookの日本語訳更新です。

nagashimam avatar Dec 15 '23 03:12 nagashimam

@nagashimam, thank you so much for putting together this pull request and helping us update the translation to the latest version of Storybook. We appreciate it 🙏 ! I'll take a closer look on my end in the coming days, but in the meantime, I was wondering if @chameleonhead would be interested in taking a pass and proofreading it. If you don't, it's more than okay, and we'll work something out.

Hope you have a fantastic day.

Stay safe.

jonniebigodes avatar Dec 15 '23 14:12 jonniebigodes

@nagashimam, one thing for you as you already have this pull request up. I've just pushed #748 with some changes to the tutorials, including the Intro to Storybook to the latest stable version of Storybook (i.e., 7.6). Can you adjust your pull request and factor these changes if you're ok with it? It's just a minor update to the Screen section of the tutorial, nothing significant.

Looking forward to hearing from you.

Have a fantastic weekend.

Stay safe

jonniebigodes avatar Dec 23 '23 21:12 jonniebigodes

@jonniebigodes Sorry for being late. I updated links and their texts, and reflected updates from 7.5 to 7.6. Could you take a look at the branch again?

nagashimam avatar Dec 27 '23 13:12 nagashimam

@nagashimam, please, no need to be sorry. I can understand if you're busy with family, work, or any other engagement that requires your attention. I really appreciate it you taking the time to get the updates in so promptly 🙇 . On my end is all good. All I wanted was for @chameleonhead to proofread it. @chameleonhead, if you don't have the time, it's all good for the same reasons as @nagashimam. We can reach out to the community and see if anyone is willing to help us proofread it and get it published.

Looking forward to hearing from you.

jonniebigodes avatar Dec 27 '23 21:12 jonniebigodes

@jonniebigodes @nagashimam Sorry for my late reply. I will start proofreading shortly. Thank you.

chameleonhead avatar Jan 12 '24 01:01 chameleonhead

@chameleonhead, thanks for following up with me on this. There is no need to be sorry whatsoever. I completely understand it; we're all busy here 🙂

jonniebigodes avatar Jan 13 '24 17:01 jonniebigodes

@jonniebigodes @nagashimam

Hi, I would love to proofread the PR if @chameleonhead is busy!

shoegaze avatar Jan 25 '24 02:01 shoegaze

@shoegaze Thank you for your proposal. I would appreciate it if you could do proofreading.

I have done following chapters.

  • get-started.md
  • simple-component.md
  • composite-component.md
  • data.md
  • screen.md (WIP)

I would like you to proofread from deploy.md to the end. (Of course you can do all.)

If it is ok, then I will send incomplete review. Thank you.

chameleonhead avatar Jan 25 '24 03:01 chameleonhead

@shoegaze, that's great to hear. I appreciate you taking the time to help @chameleonhead by proofreading the translation 🙏 ! Once it's done, let me know so that @nagashimam can address the feedback and merge the pull request, making it available to our readers.

Have a fantastic day.

Stay safe

jonniebigodes avatar Jan 25 '24 15:01 jonniebigodes

@chameleonhead (@shoegaze @jonniebigodes) Thank you for your time and effort. I'm moving to a new town next week, so I can't make time for this. I'll get back to you guys by the mid of March🙇‍♂️

nagashimam avatar Feb 20 '24 05:02 nagashimam

@nagashimam, thanks for following up with me on this. And all is good, no rush. Depending on your time frame, we can tackle these changes and update it for Storybook 8. Good luck with your move to the new town.

jonniebigodes avatar Feb 22 '24 17:02 jonniebigodes

@nagashimam I am going to re-start proofreading. Sorry for waiting so mutch. I will notice you when I finish. Thank you.

chameleonhead avatar Jul 13 '24 01:07 chameleonhead