learnstorybook.com
learnstorybook.com copied to clipboard
Chore: update react/ja/simple-component.md
Hi, this is my first OSS contribution in my life.
I've updated the Japanese translation of "Intro to Storybook" in React series. There were some differences between Japanese version and English version in the simple-component.md.
Thank you for being reviewed it :)
@tomoyuki-hiranuma, Wow, that's great to hear, and thank you very much for choosing us for your first contribution ever. We're thrilled to have you here helping us with the translation. From my end, this looks almost good. I wanted to ask you the following: Are you interested in updating the rest of the translation, as it's now a bit outdated? As there are still some chapters that require some additional changes. Applying them would help you out by learning how to get started on contributions to open source and also be a part of an amazing community, and the Japanese readers/writers would benefit from the changes tremendously.
Let me know if you're interested in doing them, you can use this pr and push in the changes. If by any reason you don't have the time, that's ok. I'll reach out to the community and ask for someone to proofread this and merge it in.
Hope you have a great week
Stay safe
@jonniebigodes , Thank you for replying and answer the questions.
Are you interested in updating the rest of the translation, as it's now a bit outdated? Of course!! I'd like to update the rest of the outdated translation and help Japanese readers/writers through my contribution.
I will push the changes to this PR sooner or later.
Thank you for asking for someone to proofread.
Stay safe
@tomoyuki-hiranuma, that's great to hear. Please do let me know once the changes are up so that I can then reach out to the community for a translator and get them addressed, if any, and merge the updates.
Have a great weekend.
@jonniebigodes , I did update the translation in two more files that I found the outdated. Thank you for waiting my contribution.
@chameleonhead sorry to bother you once again, but could you take a look at this one as well and see if it's ok, I've checked on my end (code), and it looks good. Waiting on the wording so we can merge it and get the first translation updated to feature interaction testing and A11y testing. Let me know, and we'll go from there.
@tomoyuki-hiranuma sorry for the delayed response, but it's been a couple of busy weeks, and I wasn't able to follow up with you.
Looking forward to hearing from both of you and seeing this get merged in, and seeing the first translation updated.
Hope both of you have have a great day.
Stay safe
@chameleonhead Thank you for reviewing my translations. I probably updated all pointed out. Please review it. Thank you very much.
If I have still some problems, please inform me. I will update quickly.
@tomoyuki-hiranuma
And please update gatsby-config.js
as follows.
tutorialStatus: {
'intro-to-storybook': {
react: {
de: 5.3,
en: 6.5,
es: 5.3,
fr: 6.1,
- ja: 6.4,
+ ja: 6.5,
ko: 6.4,
nl: 5.3,
pt: 5.3,
'zh-CN': 6.1,
'zh-TW': 6.3,
ar: 6.3,
},
@chameleonhead Thank you for your comments. I understand the rule of documentation in this PR. I fixed them, please check them again.
Thank you for your support.
@jonniebigodes I think it is ok to merge. Please check and merge this PR.
@chameleonhead, thanks for taking the time to review it and make the necessary suggestions. We appreciate it 🙏 . @tomoyuki-hiranuma I've just finished checking it, and it looks good on my end. Thank you for addressing the feedback so promptly. I'm going to merge this and just wanted one more thing from you, if you don't mind. Can you message me (same username) on our Discord server to wrap up the incredible work you've done in updating the translation?
Looking forward to hearing from you. I hope both of you have a great week.
Stay safe