learnstorybook.com icon indicating copy to clipboard operation
learnstorybook.com copied to clipboard

add DSD japanese translation

Open naoki8ster opened this issue 3 years ago ā€¢ 11 comments

Hi, I've finished Japanese translation of "Design Systems for Developers". I'm glad to be reviewed it :)

naoki8ster avatar Feb 01 '22 08:02 naoki8ster

I'll start proofreading. Please wait for that.

chameleonhead avatar Feb 05 '22 02:02 chameleonhead

@chameleonhead was thinking of you and was about to reach out and see if you're willing to help @naoki8ster get the translation proofread. So thankful for your initiative šŸ™ ! I'll keep an eye on this and see how it goes. Let me know once the translation is good to go and I'll gladly merge it. Thank you very much for both of you for this.

Hope y'all have a good weekend!

Stay safe

jonniebigodes avatar Feb 05 '22 18:02 jonniebigodes

@naoki8ster and @chameleonhead just a friendly reminder to check up with both of you on the status of the translation, as the proofreading began? Would both of you follow up with me so that we can continue working on this and release the translation?

Hope you both of you have a fantastic weekend!

Stay safe

jonniebigodes avatar Apr 15 '22 14:04 jonniebigodes

@naoki8star I had started proofreading, but recently I haven't had enough time to complete it. Although it is in process, I am sending the review results as it is. I have done proofreading from the beginning to the middle of the Document section.

@chameleonhead Thank you for your detailed feedbacks ! That's really helpful. I'll revise my translation referring to them although it may takes time.

I am so sorry for replying late. Maybe I can continue in a few months.

Don't worry about it. Have a nice holiday :)

naoki8ster avatar Apr 17 '22 07:04 naoki8ster

@naoki8ster, sorry for the "radio silence" (pardon the bad pun). Just checking in and see if you're willing to update the translation based on @chameleonhead 's suggestions so that we can merge it and share the amazing work that you did here with the rest of the community. Let me know, and we'll go from there.

Hope you have a great weekend.

Stay safe

jonniebigodes avatar Jul 30 '22 17:07 jonniebigodes

@jonniebigodes I'm so sorry for being lazy, I will start to update my translation promptly.

naoki8ster avatar Jul 31 '22 08:07 naoki8ster

@naoki8ster no need to be sorry, we're all busy here :)! Appreciate that you followed up with me and you're still willing to work on the translation. Looking forward to seeing the changes added.

Hope you have a great week.

Stay safe

jonniebigodes avatar Aug 01 '22 14:08 jonniebigodes

@naoki8ster wanted to follow up with you on this. I saw some of the feedback already being addressed. Are you able to address the rest of it soon so that we can merge this pull request?

Let me know, and we'll go from there.

Hope you have a great week.

Stay safe

jonniebigodes avatar Sep 12 '22 14:09 jonniebigodes

@jonniebigodes Honestly I was busy for my current project so I need to take some time to complete, but Iā€™m restarting to modify asap. I apologize for delay.

naoki8ster avatar Sep 13 '22 23:09 naoki8ster

@naoki8ster no problem, just wanted to get a sense what where we're at. Looking forward to seeing the changes come in.

jonniebigodes avatar Sep 14 '22 19:09 jonniebigodes

@jonniebigodes I've uploaded fixes to all of current reviews now, so I hope resolving all issues and the rest parts (from middle of Document section to Conclusion) to be reviewed. Thanks.

naoki8ster avatar Sep 21 '22 10:09 naoki8ster

@naoki8ster Thank you for updating. I will start proofreading again. Please wait for finishing. Thank you.

chameleonhead avatar Oct 02 '22 12:10 chameleonhead

@chameleonhead it goes without saying, thank you for taking the time to take another look at this pull request and help out @naoki8ster get it merged in. Appreciate it šŸ™ !

jonniebigodes avatar Oct 02 '22 16:10 jonniebigodes

@naoki8ster Sorry, I forgot mentioning. I have finished reviewing. Please check what I commented. Thank you.

chameleonhead avatar Oct 24 '22 21:10 chameleonhead

@chameleonhead Thank you for reviewing! I'll start editing again :)

naoki8ster avatar Oct 24 '22 22:10 naoki8ster

@naoki8ster It's been a moment since we last talked, and with that, I was wondering if you could follow up with me and let me know if you're able to add the changes so that we can merge and release this translation. We're almost at the finish line, and it would be great to get it out there.

Let me know, and we'll go from there.

Hope you have a great weekend.

Stay safe

jonniebigodes avatar Dec 18 '22 14:12 jonniebigodes

@jonniebigodes @chameleonhead I'm very sorry for not responding. Now I am fixing my translation, and I'm processing everything in order, so please wait for a little while for me to reply.

naoki8ster avatar Jan 03 '23 10:01 naoki8ster

@naoki8ster, no need to apologize whatsoever, just glad that you're willing to make the adjustments and get this translation published.

Let me know once you've made them, and we'll go from there. Sounds good?

Hope you have a great week.

Stay safe

jonniebigodes avatar Jan 03 '23 23:01 jonniebigodes

@jonniebigodes @chameleonhead Hi, I updated the first 6 chapters reviewed before, and I looked again the following chapters:

  • distribute.md
  • workflow.md
  • conclusin.md

I would be happy to check these when you are available šŸ™šŸ» Have a great weekend.

naoki8ster avatar Jan 08 '23 06:01 naoki8ster

@naoki8ster, sorry for the delayed response and for not getting back to you. I've checked, and we're in a good state, it seems, and with that out of the way, I would to throw an idea your way. If you're ok with it, that is. What do you think about merging this as it's now and sharing it so that we can give you a more than honourable mention (and you as well, @chameleonhead, for a great job proofreading) for the great work you did and also hopefully start to get some traction behind it and get more folks to help with the translation. That will give us some breathing room for the required changes for 7.0 (which will be released soon) and allow you, @chameleonhead and any other contributor willing to jump in and help maintain it. What do you think?

Looking forward to hearing feedback from both of you.

I hope you have a fantastic weekend.

Stay safe

jonniebigodes avatar Feb 19 '23 18:02 jonniebigodes

@jonniebigodes @naoki8ster

Sorry for waiting. I do not have time to proofread recently.

I agree with that. Thank you for suggestion.

chameleonhead avatar Feb 19 '23 20:02 chameleonhead

@jonniebigodes Thank you for your suggestion! I agree with it as well. I think it would be better to move on.

naoki8ster avatar Feb 20 '23 15:02 naoki8ster

That's fantastic. Thanks to both of you for following up with me and agreeing to my suggestion. I'm going to merge this tomorrow morning my time.

jonniebigodes avatar Feb 20 '23 20:02 jonniebigodes

@naoki8ster I almost forgot one small item related to your amazing contribution. If you're ok with it, can you message me on our Discord Server (same username) so that I can follow up with you?

Looking forward to hearing from you.

Hope you have a great weekend.

Stay safe

jonniebigodes avatar Feb 25 '23 19:02 jonniebigodes

@jonniebigodes Thanks for merging and inviting Discord Server! I sent a message on Discord Server:)

naoki8ster avatar Feb 26 '23 00:02 naoki8ster