chromatic-cli icon indicating copy to clipboard operation
chromatic-cli copied to clipboard

[Question] Chromatic UI review to ignore tag comments

Open dgonzalezr opened this issue 3 years ago • 3 comments

Question

We use lit-HTML on our storybook stories, unfortunately whenever the storybook gets compiled, lit will add a tag comment with an identifier on the SB stories. Is there a way to tell chromatic to ignore them? Because they are seen as changes on multiple SB stories that are not related to the changes in the matter 😞

CleanShot 2022-12-12 at 19 21 38

dgonzalezr avatar Dec 12 '22 17:12 dgonzalezr

You can ignore certain DOM elements: https://www.chromatic.com/docs/ignoring-elements/#ignore-dom-elements

But Chromatic only flags changes if there are visual changes in snapshot. The DOM diff should not trigger a change is the story doesn't change visually.

winkerVSbecks avatar May 09 '24 19:05 winkerVSbecks

@winkerVSbecks Is there an chromatic option or flag to enable DOM diff to trigger change even if no visual diffs? I'd find it useful for catching regressions related to a11y and such.

michaelsawyers avatar Jan 09 '25 20:01 michaelsawyers

@michaelsawyers not at the moment, but we are working on something for a11y testing.

winkerVSbecks avatar Jan 14 '25 14:01 winkerVSbecks