react-html-email icon indicating copy to clipboard operation
react-html-email copied to clipboard

Add Row and Col components

Open wagnermoschini opened this issue 8 years ago • 7 comments

this PR is inspired on @chromakode feedback on pr #21

//example of proposal
<Row>
  <Col>{...}</Col>
  <Col>{...}</Col>
</Row>

wagnermoschini avatar Jan 31 '17 02:01 wagnermoschini

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@de060c8).


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update de060c8...2cc06db. Read the comment docs.

codecov-io avatar Jan 31 '17 02:01 codecov-io

@chromakode Any feedback on this? This pull request has been open for several months, and it looks really handy. Is it ready to be merged into master and released? If not, is there anything I can do to help make it ready?

singingwolfboy avatar Oct 23 '17 08:10 singingwolfboy

Likewise, I'd really like to see this functionality added since I need multi-column support for my emails.

robinknox avatar Nov 02 '17 23:11 robinknox

Thanks all for your thoughts in this thread. I'm presently traveling and will look into this over the weekend.

chromaci avatar Nov 04 '17 05:11 chromaci

+1 to taking a look at merging this. I think I'm going to probably work off a fork to get these two components since it seems necessary to do a 2-column layout

searls avatar Jan 10 '18 20:01 searls

Any update on this?

giulioambrogi avatar May 16 '18 18:05 giulioambrogi

Hi, any update on this? @chromaci vacation still?

kopax avatar Oct 10 '18 16:10 kopax