let the rust bindings kill the process
Description of changes
Summarize the changes made by this PR.
Removes the node cli SIGINT handler. It was interfering with the rust handlers and the process would never stop
- Improvements & Bug fixes
- Fixes #5526
Test plan
How are these changes tested?
- [x] Tests pass locally with
pytestfor python,yarn testfor js,cargo testfor rust
Migration plan
Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?
Observability plan
What is the plan to instrument and monitor this change?
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?
Reviewer Checklist
Please leverage this checklist to ensure your code review is thorough before approving
Testing, Bugs, Errors, Logs, Documentation
- [ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
- [ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
- [ ] If appropriate, are there adequate property based tests?
- [ ] If appropriate, are there adequate unit tests?
- [ ] Should any logging, debugging, tracing information be added or removed?
- [ ] Are error messages user-friendly?
- [ ] Have all documentation changes needed been made?
- [ ] Have all non-obvious changes been commented?
System Compatibility
- [ ] Are there any potential impacts on other parts of the system or backward compatibility?
- [ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?
Quality
- [ ] Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)
Remove Node.js SIGINT Handler to Defer Process Termination to Rust Bindings
This PR removes the explicit SIGINT handler from the Node.js CLI entrypoints in both clients/js/packages/chromadb/src/cli.ts and clients/new-js/packages/chromadb/src/cli.ts. The Node.js handler was interfering with process termination as managed by the Rust bindings, resulting in the process not stopping as expected. With the handler removed, process lifecycle control is delegated entirely to the Rust layer, resolving an issue where the process would not exit properly upon receiving SIGINT. This change addresses #5526.
Key Changes
• Deleted the process.on('SIGINT', ...) block from both clients/js/packages/chromadb/src/cli.ts and clients/new-js/packages/chromadb/src/cli.ts.
• Delegated process termination control to the Rust bindings.
Affected Areas
• clients/js/packages/chromadb/src/cli.ts
• clients/new-js/packages/chromadb/src/cli.ts
This summary was automatically generated by @propel-code-bot