chroma icon indicating copy to clipboard operation
chroma copied to clipboard

[Bug]: Empty IDs don't fail validation

Open itaismith opened this issue 10 months ago • 1 comments

What happened?

Currently we allow user-provided empty IDs:

collection.add(ids=[""], documents=["hello"])

Versions

Chroma v1.0.0

Relevant log output


itaismith avatar Apr 22 '25 18:04 itaismith

@itaismith i would guess this still has to be unique, though, right? like there can only be one id = ""? just asking to get more context

EDIT: Confirmed

hesreallyhim avatar Apr 25 '25 18:04 hesreallyhim

fixed here https://github.com/chroma-core/chroma/pull/4488

jairad26 avatar May 13 '25 21:05 jairad26