chroma icon indicating copy to clipboard operation
chroma copied to clipboard

[ENH]: Huggingface Embedding Server authorization

Open MrExplode opened this issue 8 months ago • 2 comments

Description of changes

Add Bearer authorization option to HuggingFaceEmbeddingServerFunction

The corresponding issue is #4222

Test plan

How are these changes tested?

  • [ ] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Documentation has been updated.

MrExplode avatar Apr 08 '25 19:04 MrExplode

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • [ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • [ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • [ ] If appropriate, are there adequate property based tests?
  • [ ] If appropriate, are there adequate unit tests?
  • [ ] Should any logging, debugging, tracing information be added or removed?
  • [ ] Are error messages user-friendly?
  • [ ] Have all documentation changes needed been made?
  • [ ] Have all non-obvious changes been commented?

System Compatibility

  • [ ] Are there any potential impacts on other parts of the system or backward compatibility?
  • [ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • [ ] Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

github-actions[bot] avatar Apr 08 '25 19:04 github-actions[bot]

@codetheweb is there any blocker to this PR?

MrExplode avatar Apr 12 '25 09:04 MrExplode

hope you don't mind, i pushed fixes to the PR. should be good to merge now

jairad26 avatar Apr 29 '25 18:04 jairad26