chroma icon indicating copy to clipboard operation
chroma copied to clipboard

Add support for ids pre-filtering on query

Open vimota opened this issue 2 years ago • 2 comments

Description of changes

Enables support for passing in a list of IDs that will pre-filter the embeddings set in the collection before performing kNN. Addresses request in https://github.com/chroma-core/chroma/issues/224.

Test plan

Unit tests.

Documentation Changes

Updated doc strings

vimota avatar Apr 19 '23 07:04 vimota

thank you @vimota ! we are working on landing a test framework this week, and will pick this up directly after.

jeffchuber avatar Apr 20 '23 04:04 jeffchuber

Awesome to hear!

vimota avatar Apr 20 '23 06:04 vimota

Hi there ! Any update on this ?

achammah avatar Jun 08 '23 14:06 achammah

@HammadB @levand I know we've chatted about this being easy once the refactor lands. Any updated thoughts on this? I know a lot of users would find this helpful.

jeffchuber avatar Jun 21 '23 20:06 jeffchuber

@vimota thank you again for opening this PR - this is still valuable and we are going to bring it in to the API. we are going through a large refactor right now which will drop duckdb and clickhouse and so we are going to close this PR and then open a new PR in the near future. Thank you again for helping us think through this!

jeffchuber avatar Jul 04 '23 17:07 jeffchuber

@jeffchuber That makes sense, no worries. Thanks for the update and looking forward to the changes!

vimota avatar Jul 04 '23 20:07 vimota