chroma icon indicating copy to clipboard operation
chroma copied to clipboard

[Feature Request]: It should be possible to update a Collection's metadata to be None

Open levand opened this issue 2 years ago • 3 comments

Describe the problem

Currently, if you call Collection.modify(metadata=None), the system will interpret that as "do not update the metadata."

However, this means it is also not possible to intentionally update a Collection's metadata to be None.

Describe the proposed solution

Remove this ambiguity from the API.

Alternatives considered

No response

Importance

nice to have

Additional Information

No response

levand avatar Apr 18 '23 22:04 levand

What if we split Collection.modify() into two separate functions: one to update the name and another to update the metadata? This would prevent users from accidentally passing None as the metadata argument, which could cause problems if we update the current Collection.modify() function to intentionally update a Collection's metadata to be None. Splitting it into two functions would improve clarity. wdyt?

Satyam-79 avatar Apr 20 '23 15:04 Satyam-79

I like this idea - set_name(), set_metadata()

HammadB avatar May 12 '23 17:05 HammadB

jeff will test if this is still relevant

jeffchuber avatar Sep 13 '23 21:09 jeffchuber