chroma icon indicating copy to clipboard operation
chroma copied to clipboard

fix(axios): Remove max content size limit

Open jonluca opened this issue 2 years ago • 3 comments

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Remove max axios content size/length limit

Test plan

How are these changes tested? Locally

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

No

jonluca avatar Apr 17 '23 17:04 jonluca

Fixes https://github.com/chroma-core/chroma/issues/366

jonluca avatar Apr 17 '23 17:04 jonluca

A temporary workaround for anyone experiencing this is to just override the defaults

    // @ts-ignore
    this.collection.api.axios.defaults.maxContentLength = Infinity;
    // @ts-ignore
    this.collection.api.axios.defaults.maxBodyLength = Infinity;

jonluca avatar Apr 17 '23 17:04 jonluca

@jonluca thank you for this! there is another PR out to swap axois for fetch for greater support.

https://github.com/chroma-core/chroma/pull/348

I'd like to make that change, but also want to persist this. Do you know if we need something similar for fetch?

jeffchuber avatar Apr 17 '23 17:04 jeffchuber

Nope you shouldn't need anything like this for fetch - this is an internal axios config. Awesome, looking forward to that PR!

jonluca avatar Apr 17 '23 18:04 jonluca

ok great! In that case I am going to close this. thanks @jonluca for doing this however!

my goal is to land the JS stuff tonight

jeffchuber avatar Apr 17 '23 20:04 jeffchuber