chroma icon indicating copy to clipboard operation
chroma copied to clipboard

[bugfix] raises NotEnoughElementsException complaining n_results is greater than total number of elements

Open Satyam-79 opened this issue 2 years ago • 2 comments

Description of changes

FIXES collection.query() should return all elements if n_results is greater than the total number of elements in the collection. #301

  • Improvements & Bug fixes
    • added Check Number of requested results before calling knn_query.
      • n_result <= max_element
      • n_result > 0
    • collection.query() returns all elements if n_results is greater than the total number of elements in the collection.

Documentation Changes

Bugfix, no doc change required.

Satyam-79 avatar Apr 16 '23 05:04 Satyam-79

cc @HammadB

swyxio avatar Apr 16 '23 08:04 swyxio

We need to remove the 'test_number_of_elements_validation_query' test because it has become irrelevant after resolving issue #301. @HammadB

Satyam-79 avatar Apr 22 '23 11:04 Satyam-79

#537 addresses the bookkeeping of delete count, once we land that I can merge that in and move this forward.

HammadB avatar May 15 '23 22:05 HammadB