chroma icon indicating copy to clipboard operation
chroma copied to clipboard

[BUG]: Delete collection resource leak (single-node Chroma)

Open tazarov opened this issue 11 months ago • 2 comments

Description of changes

Closes #3296

The delete collection logic slightly changes to accomodate the fix without breaking the transactional integrity of self._sysdb.delete_collection. The chromadb.segment.SegmentManager.delete_segments had to change to accept the list of segments to delete instead of collection_id.

image

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Fixes the resource leak when deleting a collection

Test plan

How are these changes tested?

  • [x] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

N/A

tazarov avatar Dec 13 '24 16:12 tazarov