chroma
chroma copied to clipboard
`get_or_create_collection` should take an (optional) embedding function
Both get_collection
and create_collection
take an embedding function, get_or_create_collection
should too for parity.
So it looks like the local.py and fastapi.py implementations do in fact take the embedding function and plumb it through. But just the abstract class does not highlight it. #307 addresses this.
I wish there was a way for the typechecker to check override issues like this...
Closed by #307