chroma icon indicating copy to clipboard operation
chroma copied to clipboard

`get_or_create_collection` should take an (optional) embedding function

Open levand opened this issue 1 year ago • 1 comments

Both get_collection and create_collection take an embedding function, get_or_create_collection should too for parity.

levand avatar Apr 07 '23 17:04 levand

So it looks like the local.py and fastapi.py implementations do in fact take the embedding function and plumb it through. But just the abstract class does not highlight it. #307 addresses this.

I wish there was a way for the typechecker to check override issues like this...

HammadB avatar Apr 10 '23 19:04 HammadB

Closed by #307

HammadB avatar May 12 '23 03:05 HammadB