chroma icon indicating copy to clipboard operation
chroma copied to clipboard

[CLN] Break up test_api

Open atroyn opened this issue 1 year ago • 1 comments

test_api.py is a legacy of Chroma's launch, and provided some basic initial test coverage. We've continued to add to it as the project has evolved, and it's become a catch-all kitchen sink test file.

In practice a lot of the surface covered in test_api is better covered by our property tests. test_api.py should be broken up into separate files by API / object, and each object test should cover exceptional cases, rather than normal operation.

For example, we should save entropy in the property tests by not having them generate lists of IDs that are shorter than the lists of documents on a Collection.add call, but we should also be testing this path.

atroyn avatar Jul 28 '24 21:07 atroyn

wanting to pick this cleanup @atroyn. I looked through the test_api.py and it has multiple tests testing all kind of things. any particular suggestions on we want break the big file into smaller files? one way I can think of is we break the file into different collections API's like 1. add 2.delete 3.update 4.query 5.upsert ..

prateekagarwal3 avatar Aug 02 '24 06:08 prateekagarwal3

I can pick this up

jackhwalters avatar Aug 14 '24 20:08 jackhwalters