chroma icon indicating copy to clipboard operation
chroma copied to clipboard

on delete_collection, if the collection does not exist, more clear error is shown

Open druskacik opened this issue 2 years ago • 2 comments

Description of changes

  • Improvements & Bug fixes
    • Clearer error thrown when trying to delete unexisting collection

Test plan


import chromadb

chroma_client = chromadb.Client()
chroma_client.delete_collection('test1')

>>> ...
>>> ValueError: Collection with name test1 does not exist
# Before: IndexError: list index out of range

Documentation Changes

No documentation changes necessary.

druskacik avatar Mar 29 '23 14:03 druskacik

@druskacik thanks for this! can you write a test for this?

jeffchuber avatar Mar 29 '23 18:03 jeffchuber

@jeffchuber Sure, I added the test and also previously forgotten update to fastapi version.

druskacik avatar Mar 29 '23 22:03 druskacik

Closing this because it is very stale, but we will address this.

Issue to track https://github.com/chroma-core/chroma/issues/520

jeffchuber avatar May 11 '23 17:05 jeffchuber