chroma icon indicating copy to clipboard operation
chroma copied to clipboard

[ENH] Consume params from config

Open atroyn opened this issue 1 year ago • 3 comments

Description of changes

This PR consumes the Configuration we pass through and store. Only the HNSW segment is actually currently parametrized, so that's where we consume the configuration.

Test plan

  • Cross-version persist generates old-style configurations to test the migration for segments.
  • Property tests sample from HNSWConfigurations

Documentation Changes

Docs update do reflect the new way to set HNSW params. Expecting this to be updated in another docs pass.

TODO:

  • [ ] Distributed
  • [ ] JavaScript

atroyn avatar Jul 10 '24 16:07 atroyn

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

github-actions[bot] avatar Jul 10 '24 16:07 github-actions[bot]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • [ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • [ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • [ ] If appropriate, are there adequate property based tests?
  • [ ] If appropriate, are there adequate unit tests?
  • [ ] Should any logging, debugging, tracing information be added or removed?
  • [ ] Are error messages user-friendly?
  • [ ] Have all documentation changes needed been made?
  • [ ] Have all non-obvious changes been commented?

System Compatibility

  • [ ] Are there any potential impacts on other parts of the system or backward compatibility?
  • [ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • [ ] Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

github-actions[bot] avatar Jul 10 '24 16:07 github-actions[bot]

  • #2611 Graphite
  • #2601 Graphite
  • #2495 Graphite 👈
  • main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @atroyn and the rest of your teammates on Graphite Graphite

atroyn avatar Jul 10 '24 16:07 atroyn