chroma icon indicating copy to clipboard operation
chroma copied to clipboard

[BUG]: Cohere v5 support (Python-only)

Open tazarov opened this issue 1 year ago • 7 comments

Closes #2258

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Adds support for Cohere v5 client that introduced a new way to generate the client that breaks existing code

How are these changes tested?

  • [x] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

N/A

tazarov avatar May 30 '24 09:05 tazarov

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chroma ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 9:14am

vercel[bot] avatar May 30 '24 09:05 vercel[bot]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • [ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • [ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • [ ] If appropriate, are there adequate property based tests?
  • [ ] If appropriate, are there adequate unit tests?
  • [ ] Should any logging, debugging, tracing information be added or removed?
  • [ ] Are error messages user-friendly?
  • [ ] Have all documentation changes needed been made?
  • [ ] Have all non-obvious changes been commented?

System Compatibility

  • [ ] Are there any potential impacts on other parts of the system or backward compatibility?
  • [ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • [ ] Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

github-actions[bot] avatar May 30 '24 09:05 github-actions[bot]

This stack of pull requests is managed by Graphite. Learn more about stacking.

tazarov avatar May 30 '24 09:05 tazarov

@atroyn, this is now ready for merge after the EF split up.

tazarov avatar Jun 21 '24 15:06 tazarov

Hey @tazarov. Thank you for the PR! Is there anything I can do from the cohere-sdk side to help get it merged?

abdullahkady avatar Jul 15 '24 19:07 abdullahkady

@abdullahkady, thanks for pinging me on this. I'm waiting for @atroyn's review. Let me check up with him.

tazarov avatar Jul 16 '24 11:07 tazarov

Also addresses - https://discord.com/channels/1073293645303795742/1266257727038951444/1266264100963487775

@atroyn PTAL.

tazarov avatar Jul 26 '24 06:07 tazarov

Closing in favor of #3438

tazarov avatar Jan 08 '25 07:01 tazarov