[BUG]: Cohere v5 support (Python-only)
Closes #2258
Description of changes
Summarize the changes made by this PR.
- Improvements & Bug fixes
- Adds support for Cohere v5 client that introduced a new way to generate the client that breaks existing code
How are these changes tested?
- [x] Tests pass locally with
pytestfor python,yarn testfor js,cargo testfor rust
Documentation Changes
N/A
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| chroma | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 30, 2024 9:14am |
Reviewer Checklist
Please leverage this checklist to ensure your code review is thorough before approving
Testing, Bugs, Errors, Logs, Documentation
- [ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
- [ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
- [ ] If appropriate, are there adequate property based tests?
- [ ] If appropriate, are there adequate unit tests?
- [ ] Should any logging, debugging, tracing information be added or removed?
- [ ] Are error messages user-friendly?
- [ ] Have all documentation changes needed been made?
- [ ] Have all non-obvious changes been commented?
System Compatibility
- [ ] Are there any potential impacts on other parts of the system or backward compatibility?
- [ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?
Quality
- [ ] Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)
-
#2262
👈 (View in Graphite)
-
main
This stack of pull requests is managed by Graphite. Learn more about stacking.
@atroyn, this is now ready for merge after the EF split up.
Hey @tazarov. Thank you for the PR! Is there anything I can do from the cohere-sdk side to help get it merged?
@abdullahkady, thanks for pinging me on this. I'm waiting for @atroyn's review. Let me check up with him.
Also addresses - https://discord.com/channels/1073293645303795742/1266257727038951444/1266264100963487775
@atroyn PTAL.
Closing in favor of #3438