chroma icon indicating copy to clipboard operation
chroma copied to clipboard

[ENH] Make metadata reader() respect get_all() semantics

Open HammadB opened this issue 1 year ago • 3 comments

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Fix the python logservice batch size to some arbitrary default. We should change this later to be more principled.
    • Switch storage in memory blockfile to be BTreeMap so it follows the sort order of Arrow.
  • New functionality
    • MetadataReader should respect the semantics expected by python which are get() with no ids or filter returns everything. Eventually we will guard this with limit offset.

Test plan

How are these changes tested?

  • [x] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

HammadB avatar May 17 '24 16:05 HammadB

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chroma ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 7:59pm

vercel[bot] avatar May 17 '24 16:05 vercel[bot]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • [ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • [ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • [ ] If appropriate, are there adequate property based tests?
  • [ ] If appropriate, are there adequate unit tests?
  • [ ] Should any logging, debugging, tracing information be added or removed?
  • [ ] Are error messages user-friendly?
  • [ ] Have all documentation changes needed been made?
  • [ ] Have all non-obvious changes been commented?

System Compatibility

  • [ ] Are there any potential impacts on other parts of the system or backward compatibility?
  • [ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • [ ] Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

github-actions[bot] avatar May 17 '24 16:05 github-actions[bot]

  • #2226 Graphite
  • #2224 Graphite
  • #2222 Graphite 👈
  • main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @HammadB and the rest of your teammates on Graphite Graphite

HammadB avatar May 17 '24 16:05 HammadB