chroma icon indicating copy to clipboard operation
chroma copied to clipboard

[Bug]: Type mismatch for embedding function

Open nikhil-swamix opened this issue 1 year ago • 6 comments

What happened?

image

Versions

image

Relevant log output

No response

nikhil-swamix avatar May 16 '24 21:05 nikhil-swamix

@dglazkov @jschachter @ibratoev @levand should i open a PR refactoring the type fix? this seems to work image

After

image

it will help my github profile if i contribute such a great open source. it will take max 15 mins. thanks and regards.

nikhil-swamix avatar May 16 '24 21:05 nikhil-swamix

this seems more safe what you think? and throws no error. i think adding or type, will prevent any conflicts with image embedding. Embeddable seems some Abstract type, which is of ndarray i suppose image. pls correct if im wrong. thanks and regards. image

nikhil-swamix avatar May 16 '24 21:05 nikhil-swamix

@nikhil-swamix this was done for multimodal support. See https://docs.trychroma.com/deployment/migration#migration-to-0.4.16---november-7,-2023

sanketkedia avatar May 16 '24 21:05 sanketkedia

https://docs.trychroma.com/integrations/openai -- this gives an overview of how to use open AI embeddings

sanketkedia avatar May 16 '24 21:05 sanketkedia

I can't repro this on chromadb version 0.5.0. Can you try upgrading and see if this issue persists?

sanketkedia avatar May 16 '24 21:05 sanketkedia

yes im on chroma 0.5.0 after upgrading, and used same steps to create an embedding function. the issue of typechecking reported by pylance still persists

nikhil-swamix avatar May 17 '24 23:05 nikhil-swamix