chroma icon indicating copy to clipboard operation
chroma copied to clipboard

[CHORE]: Support for CLI in systemd examples

Open tazarov opened this issue 1 year ago • 3 comments

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Added support for running Chroma with systemd and chroma cli
    • Added example files that can be directly copied
    • Fixed Type to match how service is run (simple for cli and forking for docker compose)

Test plan

How are these changes tested?

Tested with EC2 instance

Documentation Changes

N/A

tazarov avatar May 16 '24 18:05 tazarov

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chroma ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2024 6:28am

vercel[bot] avatar May 16 '24 18:05 vercel[bot]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • [ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • [ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • [ ] If appropriate, are there adequate property based tests?
  • [ ] If appropriate, are there adequate unit tests?
  • [ ] Should any logging, debugging, tracing information be added or removed?
  • [ ] Are error messages user-friendly?
  • [ ] Have all documentation changes needed been made?
  • [ ] Have all non-obvious changes been commented?

System Compatibility

  • [ ] Are there any potential impacts on other parts of the system or backward compatibility?
  • [ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • [ ] Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

github-actions[bot] avatar May 16 '24 18:05 github-actions[bot]

  • #2217 Graphite 👈
  • main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tazarov and the rest of your teammates on Graphite Graphite

tazarov avatar May 16 '24 18:05 tazarov

Good to go once the linter passes!

beggers avatar May 24 '24 21:05 beggers