chroma icon indicating copy to clipboard operation
chroma copied to clipboard

Update embedding_functions.py

Open TALLEC-Scott opened this issue 1 year ago • 2 comments

By default set the OpenAIEmbeddingFunction API key to what is in the corresponding environment variable. This mimics the openai lib's behavior.

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • by default apply the OPENAI_API_KEY env var to the openai.api_key
  • New functionality
    • ...

Test plan

How are these changes tested?

  • [ ] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

TALLEC-Scott avatar May 16 '24 14:05 TALLEC-Scott

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chroma ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 2:21pm

vercel[bot] avatar May 16 '24 14:05 vercel[bot]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • [ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • [ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • [ ] If appropriate, are there adequate property based tests?
  • [ ] If appropriate, are there adequate unit tests?
  • [ ] Should any logging, debugging, tracing information be added or removed?
  • [ ] Are error messages user-friendly?
  • [ ] Have all documentation changes needed been made?
  • [ ] Have all non-obvious changes been commented?

System Compatibility

  • [ ] Are there any potential impacts on other parts of the system or backward compatibility?
  • [ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • [ ] Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

github-actions[bot] avatar May 16 '24 14:05 github-actions[bot]

Our underlying impl has changed and so this PR is not landable as is.

That being said - we'd still like to add this functionality and that is now tracked in this issue.

jeffchuber avatar Sep 15 '24 23:09 jeffchuber