chroma icon indicating copy to clipboard operation
chroma copied to clipboard

[BLD]: JS client 1.9.1-alpha release

Open tazarov opened this issue 1 year ago • 3 comments

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • JS version bump to 1.9.1
    • Made the error handling more robust for offline errors (works with older Nodejs 16)
    • Fixed an issue with test docker-compose file where the port was not being correctly mapped, thus making the release WF tests fail

Test plan

How are these changes tested?

  • [x] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

N/A

tazarov avatar May 07 '24 16:05 tazarov

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chroma ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2024 11:17am

vercel[bot] avatar May 07 '24 16:05 vercel[bot]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • [ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • [ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • [ ] If appropriate, are there adequate property based tests?
  • [ ] If appropriate, are there adequate unit tests?
  • [ ] Should any logging, debugging, tracing information be added or removed?
  • [ ] Are error messages user-friendly?
  • [ ] Have all documentation changes needed been made?
  • [ ] Have all non-obvious changes been commented?

System Compatibility

  • [ ] Are there any potential impacts on other parts of the system or backward compatibility?
  • [ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • [ ] Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

github-actions[bot] avatar May 07 '24 16:05 github-actions[bot]

Hi Trayan, I'm OOO most this week but I should be able to take a look Friday.

AlabasterAxe avatar May 13 '24 21:05 AlabasterAxe