[CLN] Replace let with const in JS embeddings client's OllamaEmbeddingFunction

[robinber]

Description of changes

Summarize the changes made by this PR.

• Improvements & Bug fixes
  • Replaced let with const in variable declarations where variables were not reassigned within the OllamaEmbeddingFunction of the JavaScript client for embeddings. This change enhances code quality by enforcing immutability where applicable.

Test plan

How are these changes tested?

• [x] Tests pass locally with yarn test for js
  • Ensure existing unit tests pass with the modified code to confirm that no unintended changes have occurred.

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

• No changes to user-facing APIs or documentation are necessary for this internal code quality improvement.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
chroma	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 5, 2024 7:34am

[github-actions[bot]]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• [ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
• [ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• [ ] If appropriate, are there adequate property based tests?
• [ ] If appropriate, are there adequate unit tests?
• [ ] Should any logging, debugging, tracing information be added or removed?
• [ ] Are error messages user-friendly?
• [ ] Have all documentation changes needed been made?
• [ ] Have all non-obvious changes been commented?

System Compatibility

• [ ] Are there any potential impacts on other parts of the system or backward compatibility?
• [ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• [ ] Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

[jeffchuber]

Our underlying impl has changed and so this PR is not landable as is.

That being said - we'd still like to add this functionality and that is now tracked in this issue.