[CLN] Improve JS client async errors tests

[ibratoev]

Use the jest standard Jest way for testing for rejected promises: await expect(...).rejects.throw(new Error("expected message"));.

Before, some of the tests were not failing if an error is thrown -> the tests did not really test what was expected. Skipped one such test ("collection.get should error on empty embedding"). I will fix it in a next PR.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
chroma	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 4, 2024 8:08am

[github-actions[bot]]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• [ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
• [ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• [ ] If appropriate, are there adequate property based tests?
• [ ] If appropriate, are there adequate unit tests?
• [ ] Should any logging, debugging, tracing information be added or removed?
• [ ] Are error messages user-friendly?
• [ ] Have all documentation changes needed been made?
• [ ] Have all non-obvious changes been commented?

System Compatibility

• [ ] Are there any potential impacts on other parts of the system or backward compatibility?
• [ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• [ ] Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

[jeffchuber]

@ibratoev sorry this didnt get merged at the time, this looks like a very nice change. im guessing you arent up for the large merge to get this up to date... (but let me know if you are!) - so im going to merge it and create an issue that links to this.