chroma
chroma copied to clipboard
[BUG] fix bug when receive embedding from vertex api
- fix the way to parse response using list-parsing instead of dict-parsing. see issue here.
Description of changes
Summarize the changes made by this PR.
- Improvements & Bug fixes
- fix the way to parse response from vertex api using list-parsing instead of dict-parsing
Reviewer Checklist
Please leverage this checklist to ensure your code review is thorough before approving
Testing, Bugs, Errors, Logs, Documentation
- [ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
- [ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
- [ ] If appropriate, are there adequate property based tests?
- [ ] If appropriate, are there adequate unit tests?
- [ ] Should any logging, debugging, tracing information be added or removed?
- [ ] Are error messages user-friendly?
- [ ] Have all documentation changes needed been made?
- [ ] Have all non-obvious changes been commented?
System Compatibility
- [ ] Are there any potential impacts on other parts of the system or backward compatibility?
- [ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?
Quality
- [ ] Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)
@tazarov These weird changes were fixed when I rebase the previous commit. Formatting tool leads to these changes. Thank you for your reminder.
@pig7788, this looks better. Thank you. Do you think we can also add maybe some sort of error if we don't find the response we expect? I think it would make for a good developer experience instead of returning an empty embeddings list.
@pig7788, this looks better. Thank you. Do you think we can also add maybe some sort of error if we don't find the response we expect? I think it would make for a good developer experience instead of returning an empty embeddings list.
@tazarov It is a good idea. I will add this in my code. Thanks!
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| chroma | ❌ Failed (Inspect) | May 13, 2024 3:26am |
@tazarov I add test cases that you advised and I could think of. Thank you for your suggestions. Thank @beggers too.
@tazarov I commit changes that you suggested, please confirm it, thx.
Our underlying impl has changed and so this PR is not landable as is.
That being said - we'd still like to add this functionality and that is now tracked in this issue.