chroma icon indicating copy to clipboard operation
chroma copied to clipboard

[BUG] fix bug when receive embedding from vertex api

Open pig7788 opened this issue 1 year ago • 7 comments

  1. fix the way to parse response using list-parsing instead of dict-parsing. see issue here.

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • fix the way to parse response from vertex api using list-parsing instead of dict-parsing

pig7788 avatar Apr 11 '24 02:04 pig7788

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • [ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • [ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • [ ] If appropriate, are there adequate property based tests?
  • [ ] If appropriate, are there adequate unit tests?
  • [ ] Should any logging, debugging, tracing information be added or removed?
  • [ ] Are error messages user-friendly?
  • [ ] Have all documentation changes needed been made?
  • [ ] Have all non-obvious changes been commented?

System Compatibility

  • [ ] Are there any potential impacts on other parts of the system or backward compatibility?
  • [ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • [ ] Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

github-actions[bot] avatar Apr 11 '24 02:04 github-actions[bot]

@tazarov These weird changes were fixed when I rebase the previous commit. Formatting tool leads to these changes. Thank you for your reminder.

pig7788 avatar Apr 15 '24 09:04 pig7788

@pig7788, this looks better. Thank you. Do you think we can also add maybe some sort of error if we don't find the response we expect? I think it would make for a good developer experience instead of returning an empty embeddings list.

tazarov avatar Apr 16 '24 07:04 tazarov

@pig7788, this looks better. Thank you. Do you think we can also add maybe some sort of error if we don't find the response we expect? I think it would make for a good developer experience instead of returning an empty embeddings list.

@tazarov It is a good idea. I will add this in my code. Thanks!

pig7788 avatar Apr 18 '24 02:04 pig7788

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chroma ❌ Failed (Inspect) May 13, 2024 3:26am

vercel[bot] avatar May 10 '24 09:05 vercel[bot]

@tazarov I add test cases that you advised and I could think of. Thank you for your suggestions. Thank @beggers too.

pig7788 avatar May 10 '24 10:05 pig7788

@tazarov I commit changes that you suggested, please confirm it, thx.

pig7788 avatar May 15 '24 01:05 pig7788

Our underlying impl has changed and so this PR is not landable as is.

That being said - we'd still like to add this functionality and that is now tracked in this issue.

jeffchuber avatar Sep 15 '24 23:09 jeffchuber