chroma icon indicating copy to clipboard operation
chroma copied to clipboard

[ENH][SEC]: Add warning if cors is a wild card

Open tazarov opened this issue 4 months ago • 4 comments

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Chroma will issue a warning at startup in server mode when a wild card is found the the chroma_server_cors_allow_origins

Test plan

How are these changes tested?

  • [x] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

TBD

Refs: #1841

tazarov avatar Apr 01 '24 10:04 tazarov

  • #1951 Graphite 👈
  • main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tazarov and the rest of your teammates on Graphite Graphite

tazarov avatar Apr 01 '24 10:04 tazarov

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • [ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • [ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • [ ] If appropriate, are there adequate property based tests?
  • [ ] If appropriate, are there adequate unit tests?
  • [ ] Should any logging, debugging, tracing information be added or removed?
  • [ ] Are error messages user-friendly?
  • [ ] Have all documentation changes needed been made?
  • [ ] Have all non-obvious changes been commented?

System Compatibility

  • [ ] Are there any potential impacts on other parts of the system or backward compatibility?
  • [ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • [ ] Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

github-actions[bot] avatar Apr 01 '24 10:04 github-actions[bot]

@AlabasterAxe, wdyt? Does this make sense in light of the discussion we had on https://github.com/chroma-core/chroma/issues/1841

tazarov avatar Apr 02 '24 17:04 tazarov

@AlabasterAxe, wdyt? Does this make sense in light of the discussion we had on #1841

Yeah, definitely!

AlabasterAxe avatar Apr 02 '24 19:04 AlabasterAxe