chroma icon indicating copy to clipboard operation
chroma copied to clipboard

[ENH]: Async AuthN/AuthZ

Open tazarov opened this issue 1 year ago • 2 comments

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Making AuthN middleware async
      • Authorization now supports both sync and async - it is up to the implementer of the authorization provider to decide which to use (we should generally favour Async)

Test plan

How are these changes tested?

  • [x] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

N/A

tazarov avatar Mar 28 '24 11:03 tazarov

  • #1939 Graphite 👈
  • #1938 Graphite
  • main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tazarov and the rest of your teammates on Graphite Graphite

tazarov avatar Mar 28 '24 11:03 tazarov

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • [ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • [ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • [ ] If appropriate, are there adequate property based tests?
  • [ ] If appropriate, are there adequate unit tests?
  • [ ] Should any logging, debugging, tracing information be added or removed?
  • [ ] Are error messages user-friendly?
  • [ ] Have all documentation changes needed been made?
  • [ ] Have all non-obvious changes been commented?

System Compatibility

  • [ ] Are there any potential impacts on other parts of the system or backward compatibility?
  • [ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • [ ] Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

github-actions[bot] avatar Mar 28 '24 11:03 github-actions[bot]

Closing as irrelevant after 0.5.x refactor

tazarov avatar Jun 19 '24 08:06 tazarov