chroma icon indicating copy to clipboard operation
chroma copied to clipboard

[ENH][WIP]: Unified cache dir strategy for locally running models

Open tazarov opened this issue 1 year ago • 2 comments

Addresses #792

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Allowing users to specify caching dir for their local models

Test plan

How are these changes tested?

  • [ ] Tests pass locally with pytest for python, yarn test for js

Documentation Changes

TBD

tazarov avatar Mar 01 '24 13:03 tazarov

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • [ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • [ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • [ ] If appropriate, are there adequate property based tests?
  • [ ] If appropriate, are there adequate unit tests?
  • [ ] Should any logging, debugging, tracing information be added or removed?
  • [ ] Are error messages user-friendly?
  • [ ] Have all documentation changes needed been made?
  • [ ] Have all non-obvious changes been commented?

System Compatibility

  • [ ] Are there any potential impacts on other parts of the system or backward compatibility?
  • [ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • [ ] Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

github-actions[bot] avatar Mar 01 '24 13:03 github-actions[bot]

I think we should use settings for this not a env var? Other than that looks good

HammadB avatar Apr 02 '24 22:04 HammadB