chroma icon indicating copy to clipboard operation
chroma copied to clipboard

Published 20 hours ago • verified publisher icon chroma-core

[BUG]: WAL replay warnings suppression

Open tazarov opened this issue 1 year ago • 4 comments

Refs: #1733

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Added a EmbeddingRecord flag (wal_replay) to suppress warnings in sqlite and local hnsw indices

Test plan

How are these changes tested?

  • [ ] Tests pass locally with pytest for python, yarn test for js

Documentation Changes

N/A

Colab to reproduce the issue in 0.4.23 (and prior) - https://colab.research.google.com/drive/1CtN0qGoMZoVfwQBnJE1MloLvvdv5KouE?usp=sharing

Screenshot 2024-03-02 at 21 08 12

tazarov avatar Feb 23 '24 14:02 tazarov

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • [ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • [ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • [ ] If appropriate, are there adequate property based tests?
  • [ ] If appropriate, are there adequate unit tests?
  • [ ] Should any logging, debugging, tracing information be added or removed?
  • [ ] Are error messages user-friendly?
  • [ ] Have all documentation changes needed been made?
  • [ ] Have all non-obvious changes been commented?

System Compatibility

  • [ ] Are there any potential impacts on other parts of the system or backward compatibility?
  • [ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • [ ] Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

github-actions[bot] avatar Feb 23 '24 14:02 github-actions[bot]

@atroyn, I've added a colab that reproduces the problem.

The gist is that we emit all entries from the WAL up to the index' MAX seqId, if there are duplicate entries (e.g. an item was added/removed multiple times) the respective index reports the duplicates as warnings.

tazarov avatar Mar 02 '24 19:03 tazarov

Similar issue was reported by MemGPT - https://discord.com/channels/1073293645303795742/1205288940488359998

tazarov avatar Mar 02 '24 19:03 tazarov

This is potentially made redundant by #2062

tazarov avatar Apr 26 '24 07:04 tazarov

Close in favor of #2062

tazarov avatar May 16 '24 06:05 tazarov