chroma
chroma copied to clipboard
[BUG]: Enable FK constraints for all TX
Description of changes
Summarize the changes made by this PR.
- Improvements & Bug fixes
- Enabled FK constraints on all connections
- Fixed FK for segments to collections
- Implemented a new mechanism for disabling/enabling FKs for migration files (required to retrospectively apply it to tenants and databases migration as it was breaking FK constraints)
- Removed unnecessary embedding metadata cleanup (taken care of by FKs)
- Added utils lib to generate correct (topologically sorted in reverse) DROP statements for tables according to FK constraints
- Fixed client_test.py failing test - the test server dir was not removed, so subsequent tests were failing
- Fixed test_segment_manager.py where collection names were causing FK constraint failures
Test plan
How are these changes tested?
- [x] Tests pass locally with
pytest
for python,yarn test
for js
Documentation Changes
N/A
Reviewer Checklist
Please leverage this checklist to ensure your code review is thorough before approving
Testing, Bugs, Errors, Logs, Documentation
- [ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
- [ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
- [ ] If appropriate, are there adequate property based tests?
- [ ] If appropriate, are there adequate unit tests?
- [ ] Should any logging, debugging, tracing information be added or removed?
- [ ] Are error messages user-friendly?
- [ ] Have all documentation changes needed been made?
- [ ] Have all non-obvious changes been commented?
System Compatibility
- [ ] Are there any potential impacts on other parts of the system or backward compatibility?
- [ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?
Quality
- [ ] Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)
@HammadB, this is ready to go
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
chroma | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 1, 2024 4:23pm |