chroma icon indicating copy to clipboard operation
chroma copied to clipboard

[ENH] New Embedding Function - VoyageAIEmbeddingFunction

Open ha-sante opened this issue 1 year ago • 7 comments

Description of changes

Summarize the changes made by this PR.

  • New functionality - Addition of VoyageAI to the list of embedding functions supported natively.

Test plan

How are these changes tested?

  • [X] Executed Against py test_voyage_ef.py

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

  • https://github.com/chroma-core/docs/pull/155

ha-sante avatar Nov 03 '23 12:11 ha-sante

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • [ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • [ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • [ ] If appropriate, are there adequate property based tests?
  • [ ] If appropriate, are there adequate unit tests?
  • [ ] Should any logging, debugging, tracing information be added or removed?
  • [ ] Are error messages user-friendly?
  • [ ] Have all documentation changes needed been made?
  • [ ] Have all non-obvious changes been commented?

System Compatibility

  • [ ] Are there any potential impacts on other parts of the system or backward compatibility?
  • [ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • [ ] Is this code of a unexpectedly high quality (Readbility, Modularity, Intuitiveness)

github-actions[bot] avatar Nov 03 '23 12:11 github-actions[bot]

@ha-sante Would you be ok to make the texts -> input change?

HammadB avatar Dec 04 '23 19:12 HammadB

Thanks for the recall @HammadB - will resubmit the changes before tomorrow ending gmt. - Thanks

ha-sante avatar Dec 04 '23 20:12 ha-sante

@ha-sante, thank you so much for the hard work. With your permission, I'll do the following:

  • [x] Rebase so we don't have conflicts
  • [ ] ~~Add JS support (unless already done in a separate PR)~~
  • [x] Add tests for both Python and ~~JS (unless already part of another PR)~~

tazarov avatar Apr 07 '24 10:04 tazarov

@tazarov You have my permission 👍

ha-sante avatar Apr 07 '24 10:04 ha-sante

Related PR - https://github.com/chroma-core/chroma/pull/1871. I asked the OP to only merge the JS functionality

tazarov avatar Apr 08 '24 10:04 tazarov

merge it man, feature is more important than minor inconsistencies. atleast chroma dev branch should be have canary like releases. fast. thanks.

nikhil-swamix avatar May 16 '24 02:05 nikhil-swamix

Hi , please merge, im having to write seperate utils for the same, and code is getting scattered.

nikhil-swamix avatar May 20 '24 03:05 nikhil-swamix

@nikhil-swamix, thank your patience and hard work. We are refactoring the EFs, and I'll get back to you within the week.

tazarov avatar May 20 '24 07:05 tazarov

@nikhil-swamix, thank your patience and hard work. We are refactoring the EFs, and I'll get back to you within the week.

thanks very much! your commitment to opensource is helping thousands.

nikhil-swamix avatar May 23 '24 14:05 nikhil-swamix

@atroyn, this is rebased and tested, and the docs are updated.

tazarov avatar Jun 21 '24 16:06 tazarov

Our underlying impl has changed and so this PR is not landable as is.

That being said - we'd still like to add this functionality and that is now tracked in this issue.

jeffchuber avatar Sep 15 '24 20:09 jeffchuber

Our underlying impl has changed and so this PR is not landable as is.

That being said - we'd still like to add this functionality and that is now tracked in this issue.

Im really concerned, the way chroma is heading. so this guy's few hour effort for PR is now garbage. which would handicap lot of enthusiasts and scared from contributing. i have most utils seperately written just as inbuilt stuffs just break or show type error/mismatch with new versions. no offence just my perspective. regards.

nikhil-swamix avatar Sep 15 '24 23:09 nikhil-swamix