Christian Neumann

Yes, the try/catch is not covered by a test. We talked about that before: https://github.com/maplibre/maplibre-gl-js/pull/4551#discussion_r1743515541 Best would be to have more insights from someone who knows more about the recalculation...

No, did you see the discussion at https://github.com/maplibre/maplibre-gl-js/pull/4551#discussion_r1782227028 ?

I can't reproduce the crash any more in the current main branch. Still kept the added surface padding (camera stays not directly on the ground), as it prevents some graphic...

> But there seems to be a regression with the `transformCameraUpdate`. Possibly because the camera transform is updated in the new changes without considering this option. Needs a closer look....

> @chrneumann is this ready to me merged? Yes, it's ready.

Waiting for #4299 (fixes camera jumps) to be approved before polishing this PR.

Found more problems (fixed in https://github.com/maplibre/maplibre-gl-js/pull/4300/commits/f6bdf15fe07a039135755f38a231d54c40ced9c7) with the direct manipulation of the transform, which leads to jumps and other problems. One should keep in mind that there might be other...

> This looks good! There are failing render tests though, please see if there's a need to update the expected image of the fog tests due to this fix. Yes,...

Build size is bigger, I think that's fine?

> Really? This seems strange... is the pitch this high? Are you sure the threshold is not too tight or something? I removed the padding altogether. Makes code simpler and...