bookmarkleter icon indicating copy to clipboard operation
bookmarkleter copied to clipboard

Babel Minify seems enabled regardless of checkbox

Open rillig opened this issue 5 years ago • 1 comments

I entered the following JavaScript snippet:

var sel = document.getSelection();
if (sel === null || sel === undefined)
    sel = prompt('Suchbegriff:', '');
if (sel !== null && sel !== undefined && sel !== '')
    location.href = 'https://de.wikipedia.org/w/index.php?search=' + encodeURIComponent(sel);

The "Minify code" option was unchecked. The generated bookmarklet was:

javascript:void%20function(){var%20a=document.getSelection();(null===a||a===void%200)%26%26(a=prompt(%22Suchbegriff:%22,%22%22)),null!==a%26%26a!==void%200%26%26%22%22!==a%26%26(location.href=%22https://de.wikipedia.org/w/index.php%3Fsearch=%22+encodeURIComponent(a))}();

This pretty much looks like the result of a minifier. The result does not change when I check and uncheck the Babel checkbox.

rillig avatar Nov 27 '19 16:11 rillig

I just noticed in the code that minify is always set to true, and that the minify checkbox doesn't map to the minify option but to the mangle option. Looks like an oversight to me.

rillig avatar Nov 27 '19 17:11 rillig