Chris Pearce comments

Results 57 comments of


                                            Chris Pearce

Better support for custom types

That is correct. If you agree also: We would also accept a single variable/method reference. Ie. ``` javascript static propTypes = { prop: validationFunction // or prop: validationFunction(props, propName, ...)...

Better support for custom types

My last comment may be a second iteration though looking at the time I have available ;)

Better support for custom types

This was exactly what I was just thinking of as well. Not unreasonable to expect users may want to have more granular namespacing I think we take the last property...

Better support for custom types

Any quick pointers to get me going quicker will be appreciated :P

onAfterResponse is called with inconsistent context object to types

I've seen same behaviour when using `autocannon`. Explicitly using GET here. Eg. ```bash bunx --bun autocannon -c 100 -d 10 -m GET http://localhost:3000/health ``` Upon inspection I had used the...

onAfterResponse is called with inconsistent context object to types

Looking at all the issues related to error handling and `onAfterResponse` I'm wondering if the types are just wrong here. Ie. in a case of an error it seems elysia...

onAfterResponse is called with inconsistent context object to types

Did a binary search through npm versions to find this "breaks" in `[email protected]`. When handling a path elysia doesn't know about (so expected 404) `[email protected]` never calls `onAfterResponse` with a...