multicoin-address-validator icon indicating copy to clipboard operation
multicoin-address-validator copied to clipboard

Fix AVAX, include AVAXC

Open 0xcharchar opened this issue 2 years ago • 2 comments

The current AVAX implementation is actually for the C-Chain, which is actually AVAXC according to SLIP-0044.

These changes are breaking but accomplish two things:

  • Fix the AVAX implementation to parse X- & P- chains instead of the C-Chain
  • Add in AVAXC support to continue parsing the C-Chain

A couple questions I have:

  • Would you like the dist/ folder committed as well?
  • Would you prefer the ID stripping to be its own function? My thinking was that it was unnecessary abstraction to make it a function

References:

0xcharchar avatar Apr 24 '22 15:04 0xcharchar

The error in Travis looks like a problem with Node 18 and Travis, not the changes here.

0xcharchar avatar Apr 24 '22 15:04 0xcharchar

Sorry to ping you @christsim, is there any chance I can get a review on this?

0xcharchar avatar Jun 01 '22 13:06 0xcharchar