multicoin-address-validator icon indicating copy to clipboard operation
multicoin-address-validator copied to clipboard

Published 20 hours ago • verified publisher icon christsim

Add Groestlcoin (GRS)

Open HashEngineering opened this issue 5 years ago • 9 comments

This PR will add support for Groestlcoin addresses. Groestlcoin uses a new hash for the checksum of the addresses and that is imported from npm instead of including the file directly with the hash function as with Blake.

Since according to my comment on issue #10 this library only supports bech32 addresses for bitcoin, the tests for bech32 addresses have been commented out.

HashEngineering avatar Feb 16 '20 05:02 HashEngineering

If this PR needs to be rebased I am happy to do that if you don't use Squash and Merge.

HashEngineering avatar Feb 16 '20 05:02 HashEngineering

@christsim Let us know if this PR is ok to get merged or something else needs to be fixed also

gruve-p avatar Mar 02 '20 10:03 gruve-p

@christsim Fixed conflicts and ready for review. This has been implemented and tested on Trezor: https://github.com/trezor/trezor-address-validator/commit/b213f7a37495be5fb1a1ca0db2095e9809f2ccab

gruve-p avatar May 05 '20 21:05 gruve-p

@christsim Fixed conflicts again and ready for review.

gruve-p avatar May 24 '20 13:05 gruve-p

@christsim Let us know if you have a chance to review

gruve-p avatar Nov 10 '20 08:11 gruve-p

@christsim rebased on upstream to fix conflicts

gruve-p avatar Feb 12 '21 10:02 gruve-p

@christsim rebased

gruve-p avatar Oct 09 '21 19:10 gruve-p

@christsim rebased again

gruve-p avatar Feb 03 '22 20:02 gruve-p

@christsim Is this PR unwanted?

gruve-p avatar Dec 13 '22 14:12 gruve-p