laravel-factories-reloaded icon indicating copy to clipboard operation
laravel-factories-reloaded copied to clipboard

Published 20 hours ago • verified publisher icon christophrumpel

PHP 8 Support

Open DaJoTo opened this issue 4 years ago • 7 comments

Is there any chance you can bump require version to support PHP 8?

It's great that you've made things compatible with with Laravel 8, perhaps something in keeping with their approach ("^7.4|^8.0")?

Thanks for the hard work on this package, love it. Not a fan of the Laravel 8 factories approach.

DaJoTo avatar Dec 09 '20 01:12 DaJoTo

Hey @DaJoTo, thanks for the reminder and that you like the package. Still on my list. Will give it a look 👍

christophrumpel avatar Dec 09 '20 07:12 christophrumpel

Ok I took a look today. One problem is that I use BetterReflection for this package which does not have PHP 8 support yet. https://github.com/Roave/BetterReflection/issues/701

I might have to wait until they release a new version.

christophrumpel avatar Dec 09 '20 15:12 christophrumpel

Looks like someone has done most of the work already, just needs PRing and ensuring it doesn't break tests. I'll see if I can invest some time into it.

DaJoTo avatar Dec 09 '20 22:12 DaJoTo

Just checked, still no PHP8 support for BetterReflection package =/

christophrumpel avatar Mar 31 '21 14:03 christophrumpel

@christophrumpel There is a php 8 update now. Are you willing to upgrade yours or did you abandon the development?

EranNL avatar Mar 29 '22 09:03 EranNL

Hey, I dont use it myself anymore but Im willing to upgrade with some help. Would you do a PR?

christophrumpel avatar Mar 29 '22 10:03 christophrumpel

Sure! I just opened a PR.

EranNL avatar Mar 30 '22 07:03 EranNL