HISE icon indicating copy to clipboard operation
HISE copied to clipboard

SFZ Imports do not work for most SFZs - Missing Parent

Open lunacyaudio opened this issue 2 years ago • 3 comments

HISE only allows SFZ imports for SFZ files with <global> in the file, otherwise it will throw the error no valid parent for group. Most SFZ files do not have this parent in the file, so they are unusable without adding the parent manually.

Here is an SFZ file which imports properly into HISE: https://www.pianobook.co.uk/packs/halfsize-nylon-guitar-ds/ Here is an SFZ file that won't import without manually adding <global> to the file: https://www.pianobook.co.uk/packs/the-bells-of-woodland-heights/

Suggestion: Add <global> automatically to any imported SFZ which is missing it.

lunacyaudio avatar Apr 18 '22 20:04 lunacyaudio

This is fixed now. Let me know if you find other SFZ files that don't load...

christoph-hart avatar Apr 23 '22 16:04 christoph-hart

I've tested this a bit more and noticed it still has some issues with certain SFZ files. Here's an example of one which throws the error no valid parent for group: https://www.pianobook.co.uk/packs/kawai-old-toy-piano/

It will only work if you add a <group> tag

Here is another SFZ which will only work if you add a global tag to the top of the file:

https://www.pianobook.co.uk/packs/the-omni-master-key/

lunacyaudio avatar Apr 28 '22 05:04 lunacyaudio

Alright, those are fixed too. I'll keep this open for the case that there are more SFZ glitches (but I think now all missing tags (global, group, control) are handled correctly).

christoph-hart avatar May 02 '22 13:05 christoph-hart